From e065ab2cd7432fa1683b8833a51973c2418f43d219dc1ebe5aabc9433d94dbdc Mon Sep 17 00:00:00 2001
From: Thomas Oettli <spacefreak@noop.ch>
Date: Sat, 22 Aug 2026 06:48:59 +0200
Subject: [PATCH] use dedicated variable update_pbc for the install flag

---
 pbc | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/pbc b/pbc
index 7369db5..18109cf 100755
--- a/pbc
+++ b/pbc
@@ -189,7 +189,8 @@ PBC=$(command -v proxmox-backup-client)
 PBC_DOWNLOAD_URL='http://download.proxmox.com/debian/pbs-client/dists/trixie/main/binary-amd64'
 ETC_DIR="/etc/$SCRIPT"
 
-FULL_HELP=false
+full_help=false
+update_pbc=false
 
 action=''
 cfgfile="$ETC_DIR/config"
@@ -210,7 +211,7 @@ while (( $# > 0 )); do
         exit 0
       ;;
       -H|--full-help)
-        FULL_HELP=true
+        full_help=true
       ;;
       -*)
         echo "Error: invalid option: $opt" >&2
@@ -225,7 +226,7 @@ while (( $# > 0 )); do
   elif [ "$action" == "install" ]; then
     case "$opt" in
       -u|--update)
-        args+=('true')
+        update_pbc=true
       ;;
       -*)
         echo "Error: invalid option: $opt" >&2
@@ -252,7 +253,7 @@ if [ -f "$cfgfile" ]; then
   (( 8#$perms & 0007 )) && echo "Warning: $cfgfile is readable by others!" >&2
 fi
 
-if $FULL_HELP; then
+if $full_help; then
   [ -f "$cfgfile" ] && source "$cfgfile"
   PBC=${PBC:-/usr/local/bin/proxmox-backup-client}
   full_usage
@@ -369,14 +370,12 @@ case "$action" in
     pbc-mount "$snapshot" "$archive" "$target" || exit $?
   ;;
   install)
-    update=${args[0]:-false}
-
     (( EUID != 0 )) && echo "Error: installation only works as root!" >&2 && exit 1
 
-    install_proxmox_backup_client "$update" || exit $?
+    install_proxmox_backup_client "$update_pbc" || exit $?
 
     if dpkg -s jq &>/dev/null; then
-      $update && echo "Info: skip update of jq, package is managed by package manager" || echo "Info: jq is already installed"
+      $update_pbc && echo "Info: skip update of jq, package is managed by package manager" || echo "Info: jq is already installed"
     else
       apt_get_install jq || exit $?
     fi
@@ -389,7 +388,7 @@ case "$action" in
     fi
 
     if [ -f "$SCRIPT_DIR/config.example" ]; then
-      if $update || [ ! -f "$ETC_DIR/config.example" ]; then
+      if $update_pbc || [ ! -f "$ETC_DIR/config.example" ]; then
         echo "Install example config to $ETC_DIR/config.example ..."
         ! install -m 0640 "$SCRIPT_DIR/config.example" "$ETC_DIR/config.example" && echo "Error installing file!" >&2 && exit 4
       fi