Use hash_equals method to compare the hashes.

This commit is contained in:
Marcin Łojewski
2018-02-28 23:53:33 +01:00
parent a6a502fe7c
commit 3d901e3fc2
7 changed files with 7 additions and 7 deletions

View File

@@ -50,6 +50,6 @@ class Cleartext implements HashAlgorithm
*/ */
public function checkPassword($password, $dbHash) public function checkPassword($password, $dbHash)
{ {
return $password === $dbHash; return hash_equals($dbHash, $password);
} }
} }

View File

@@ -44,7 +44,7 @@ class CourierMD5 implements HashAlgorithm
*/ */
public function checkPassword($password, $dbHash) public function checkPassword($password, $dbHash)
{ {
return $this->getPasswordHash($password) === $dbHash; return hash_equals($dbHash, $this->getPasswordHash($password));
} }
/** /**

View File

@@ -42,7 +42,7 @@ class CourierMD5Raw implements HashAlgorithm
*/ */
public function checkPassword($password, $dbHash) public function checkPassword($password, $dbHash)
{ {
return $this->getPasswordHash($password) === $dbHash; return hash_equals($dbHash, $this->getPasswordHash($password));
} }
/** /**

View File

@@ -44,7 +44,7 @@ class CourierSHA1 implements HashAlgorithm
*/ */
public function checkPassword($password, $dbHash) public function checkPassword($password, $dbHash)
{ {
return $this->getPasswordHash($password) === $dbHash; return hash_equals($dbHash, $this->getPasswordHash($password));
} }
/** /**

View File

@@ -44,7 +44,7 @@ class CourierSHA256 implements HashAlgorithm
*/ */
public function checkPassword($password, $dbHash) public function checkPassword($password, $dbHash)
{ {
return $this->getPasswordHash($password) === $dbHash; return hash_equals($dbHash, $this->getPasswordHash($password));
} }
/** /**

View File

@@ -42,7 +42,7 @@ class MD5 implements HashAlgorithm
*/ */
public function checkPassword($password, $dbHash) public function checkPassword($password, $dbHash)
{ {
return $this->getPasswordHash($password) === $dbHash; return hash_equals($dbHash, $this->getPasswordHash($password));
} }
/** /**

View File

@@ -42,7 +42,7 @@ class SHA1 implements HashAlgorithm
*/ */
public function checkPassword($password, $dbHash) public function checkPassword($password, $dbHash)
{ {
return $this->getPasswordHash($password) === $dbHash; return hash_equals($dbHash, $this->getPasswordHash($password));
} }
/** /**